This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Fix Instance() method of Singleton classes #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, make sure that all the Instance() methods of the same class always use the same instantiation.
5 tasks
azeey
reviewed
Dec 3, 2022
|
What is your opinion regarding merging this @scpeters @azeey ? We just hit a regression involving this patch in conda-forge (see conda-forge/gazebo-feedstock#161), to avoid this in the future it would be great if we could get this eventually in an official release. |
scpeters
reviewed
Feb 17, 2023
Sure, we can also just wait for the ROS tests before even merging this PR, I am not particulary in a hurry on this one. I am just afraid that at some point the problem that affected conda-forge macOS builds also started to affect other builds (for example homebrew builds as soon as a new version of Apple Clang is released). |
scpeters
approved these changes
Feb 19, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, make sure that all the Instance() methods of the same class always use the same instantiation.
🦟 Bug fix
Fixes conda-forge/gazebo-feedstock#148 .
Summary
This should fix all the cases in which multiple instances of a Singleton classes were observed, as for example in conda-forge/macOS build of Classic Gazebo (see conda-forge/gazebo-feedstock#148 (comment)). The fix was inspired from gazebosim/gz-sim#1725 and from the related PRs:
Thanks a lot to @azeey for suggesting the correct fix in conda-forge/gazebo-feedstock#152 (comment) .
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.